-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add viewport meta #1
base: master
Are you sure you want to change the base?
Conversation
Update requirejs Add .idea to .gitignore
Hey Sean, Thanks for taking the time to drop all these PRs in here, this is awesome. I'm entirely good with these changes, just a couple points:
/cc @slang800 @samccone @declandewet for comment |
I like the commented out idea. Though if we were to add it as a default we might as well go the full way of including the HTML5 boilerplate... |
I'd be happy to support an html5 boilerplate template as well if someone wants to contribute that. I feel like the point of the templates originally was to allow anyone to make their own template that's exactly how they want it and set that as the default if they are not totally into our defaults. The |
I was just thinking that to be honest. And that's actually what I did. I use a custom template that gives me |
Well let's see what you got - post it up! If people like it and you want we could move it to this org and ship with it by default. |
Well that's literally all it does at the moment, I just use those so often since discovering Jeet. Maybe I'll upload it some time. |
@Jenius, what's the status on this PR? I still think that including the
Then it would be clear. @declandewet, as per your polyfill libraries, I think those should be left out, maybe for a |
I left a detailed comment on it a number of months ago and it looks like you never responded. I have about the same view still - I'd like for the additions to the gitignore to be removed and for the mobile tag to be commented by default. I think the idea you just posted with the clarifying comment makes sense : ) |
Update requirejs
Add .idea to .gitignore